Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added fix for listen directives in stub status and plus API configs #348

Merged
merged 1 commit into from
Jun 16, 2023
Merged

added fix for listen directives in stub status and plus API configs #348

merged 1 commit into from
Jun 16, 2023
+138 −8

Conversation

oliveromahony
Copy link
Contributor

@oliveromahony oliveromahony commented Jun 16, 2023 •
edited
Loading

Proposed changes

Changed the way we parse plus and stub status from configs so it works with :port and port only formats. Also parse = in location block.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Jun 16, 2023 •
edited
Loading

✅ Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 9d45a29
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/648c4654bd5d6a0008613c39

@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks dependencies labels Jun 16, 2023
@oliveromahony oliveromahony merged commit 95054a2 into main Jun 16, 2023
@oliveromahony oliveromahony deleted the fix-listen-for-stub-and-plus-api branch June 16, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aphralG aphralG aphralG approved these changes

@craigell craigell craigell approved these changes

@dhurley dhurley dhurley approved these changes

@Dean-Coakley Dean-Coakley Awaiting requested review from Dean-Coakley

Assignees
No one assigned
Labels
bug Something isn't working chore Pull requests for routine tasks dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliveromahony @dhurley @craigell @aphralG